Skip to content

build: fixes local runnability of itk tests and adds readme on how to setup#946

Merged
kdziedzic70 merged 2 commits into1.0-devfrom
fix-run-itk-locally
Apr 9, 2026
Merged

build: fixes local runnability of itk tests and adds readme on how to setup#946
kdziedzic70 merged 2 commits into1.0-devfrom
fix-run-itk-locally

Conversation

@kdziedzic70
Copy link
Copy Markdown

Description

PR fixes ability to run itk tests locally and adds readme with proper instructions on how to set up the environment for that.

Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@kdziedzic70 kdziedzic70 requested a review from a team as a code owner April 8, 2026 09:23
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a README with instructions for running Integration Test Kit (ITK) tests locally using Podman and updates the run_itk.sh script to use system-level Git configurations. A review comment points out that applying system-level Git configurations within the container requires root privileges and suggests adding the -u root flag to the docker exec commands to ensure they execute successfully.

@kdziedzic70 kdziedzic70 force-pushed the fix-run-itk-locally branch from 9b5ed74 to bc8713c Compare April 8, 2026 09:25
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026

🧪 Code Coverage (vs 1.0-dev)

⬇️ Download Full Report

No coverage changes.

Generated by coverage-comment.yml

@kdziedzic70 kdziedzic70 force-pushed the fix-run-itk-locally branch from bc8713c to 7342ef6 Compare April 8, 2026 09:30
@ishymko ishymko changed the title fix: fixes local runnability of itk tests and adds readme on how to setup build: fixes local runnability of itk tests and adds readme on how to setup Apr 8, 2026
@kdziedzic70 kdziedzic70 force-pushed the fix-run-itk-locally branch from 7342ef6 to 25716a0 Compare April 8, 2026 11:27
@kdziedzic70 kdziedzic70 force-pushed the fix-run-itk-locally branch from 25716a0 to 3154e0f Compare April 9, 2026 08:23
@kdziedzic70 kdziedzic70 merged commit 39e32e9 into 1.0-dev Apr 9, 2026
18 checks passed
@kdziedzic70 kdziedzic70 deleted the fix-run-itk-locally branch April 9, 2026 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants